ggershinsky commented on code in PR #2639:
URL: https://github.com/apache/iceberg/pull/2639#discussion_r949093079
##########
parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java:
##########
@@ -225,6 +243,36 @@ private WriteBuilder
createContextFunc(Function<Map<String, String>, Context> ne
return this;
}
+ private FileEncryptionProperties
createEncryptionProperties(NativeFileCryptoParameters nativeParameters) {
+ Preconditions.checkArgument(nativeParameters != null, "Null native
crypto parameters");
+
+ ParquetCipher parquetEncryptionAlgorithm;
+ if (nativeParameters.encryptionAlgorithm() == null) {
+ parquetEncryptionAlgorithm = ParquetCipher.AES_GCM_V1; // default
+ LOG.info("No encryption algorithm specified. Using Parquet default -
AES_GCM_V1");
+ } else {
+ EncryptionAlgorithm icebergEncryptionAlgorithm =
nativeParameters.encryptionAlgorithm();
+ if (icebergEncryptionAlgorithm.equals(EncryptionAlgorithm.AES_GCM)) {
+ parquetEncryptionAlgorithm = ParquetCipher.AES_GCM_V1;
+ } else if
(icebergEncryptionAlgorithm.equals(EncryptionAlgorithm.AES_GCM_CTR)) {
+ parquetEncryptionAlgorithm = ParquetCipher.AES_GCM_CTR_V1;
+ } else {
+ throw new ParquetCryptoRuntimeException("Can't create parquet
encryption properties - " +
+ "unsupported algorithm: " +
nativeParameters.encryptionAlgorithm());
+ }
+ }
+
+ ByteBuffer footerDataKey = nativeParameters.fileKey();
+ if (null == footerDataKey) {
Review Comment:
I believe ORC works with column keys, not files keys. So this is a
parquet-specific check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
