kbendick commented on code in PR #5568:
URL: https://github.com/apache/iceberg/pull/5568#discussion_r949426449
##########
core/src/test/java/org/apache/iceberg/TestTransaction.java:
##########
@@ -130,12 +133,14 @@ public void testMultipleOperationTransaction() {
statuses(Status.DELETED, Status.EXISTING));
Assert.assertEquals(
- "Table should have a snapshot for each operation", 2,
readMetadata().snapshots().size());
+ "Table should have a snapshot for each operation", 3,
readMetadata().snapshots().size());
validateManifestEntries(
- readMetadata().snapshots().get(0).allManifests(table.io()).get(0),
+ readMetadata().snapshots().get(1).allManifests(table.io()).get(0),
ids(appendSnapshot.snapshotId(), appendSnapshot.snapshotId()),
files(FILE_A, FILE_B),
statuses(Status.ADDED, Status.ADDED));
+
+
org.assertj.core.api.Assertions.assertThat(table.history()).containsAll(initialHistory);
Review Comment:
You might consider asserting on the entire history that should be there --
which should be the initial history + the one entry post
`txn.commitTransaction()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
