Fokko opened a new pull request, #5583:
URL: https://github.com/apache/iceberg/pull/5583

   A breaking change has been reverted:
   https://github.com/pydantic/pydantic/releases/tag/v1.9.2
   
   This means that it is now a str instead of a bool.
   It defaults to shallow, which is fine for us.
   
   ```
   tests/catalog/test_base.py::test_rename_table
     
/Users/fokkodriesprong/Desktop/iceberg/python/tests/catalog/test_base.py:117: 
DeprecationWarning: `copy_on_model_validation` should be a string: 'deep', 
'shallow' or 'none'
       self.__tables[to_identifier] = Table(
   
   tests/catalog/test_hive.py::test_create_table
   tests/catalog/test_hive.py::test_create_table
   tests/catalog/test_hive.py::test_create_table
     
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/catalog/hive.py:308: 
DeprecationWarning: `copy_on_model_validation` should be a string: 'deep', 
'shallow' or 'none'
       metadata = TableMetadataV2(
   
   tests/catalog/test_hive.py: 16 warnings
     
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/catalog/hive.py:258: 
DeprecationWarning: `copy_on_model_validation` should be a string: 'deep', 
'shallow' or 'none'
       return Table(identifier=(table.dbName, table.tableName), 
metadata=metadata, metadata_location=metadata_location)
   
   tests/catalog/test_hive.py::test_create_table
   tests/catalog/test_hive.py::test_create_table
   tests/catalog/test_hive.py::test_create_table
     
/Users/fokkodriesprong/Desktop/iceberg/python/tests/catalog/test_hive.py:261: 
DeprecationWarning: `copy_on_model_validation` should be a string: 'deep', 
'shallow' or 'none'
       assert metadata == TableMetadataV2(
   
   tests/catalog/test_hive.py: 1 warning
   tests/catalog/test_rest.py: 2 warnings
   tests/table/test_metadata.py: 1 warning
   tests/table/test_partitioning.py: 9 warnings
     
/Users/fokkodriesprong/Desktop/iceberg/python/pyiceberg/table/partitioning.py:96:
 DeprecationWarning: `copy_on_model_validation` should be a string: 'deep', 
'shallow' or 'none'
       super().__init__(**data)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to