xuzhiwen1255 opened a new pull request, #5586:
URL: https://github.com/apache/iceberg/pull/5586
**What has changed**
In RowDataTaskWriterFactory, the parameter in the OutputFileFactory should
be taskid instead of attemptid. My PR fixes this problem.
```java
public void initialize(int taskId, int attemptId) {
this.outputFileFactory = OutputFileFactory.builderFor(table, taskId,
attemptId)
.format(format)
.build();
}
public static Builder builderFor(Table table, int partitionId, long
taskId) {
return new Builder(table, partitionId, taskId);
}
```
If we need to pass in taskid, I think we can rename it to avoid confusion of
concepts.
@rdblue What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
