rdblue commented on code in PR #5574:
URL: https://github.com/apache/iceberg/pull/5574#discussion_r950332646


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/functions/BucketFunction.java:
##########
@@ -205,7 +211,6 @@ public static Integer invoke(int numBuckets, UTF8String 
value) {
         return null;
       }
 
-      // TODO - We can probably hash the bytes directly given they're already 
UTF-8 input.

Review Comment:
   Yeah, we should be able to pass the backing byte array. Let's do this in a 
follow-up for 3.3.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to