wypoon commented on code in PR #4588:
URL: https://github.com/apache/iceberg/pull/4588#discussion_r950626188
##########
spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkReaderDeletes.java:
##########
@@ -130,7 +140,8 @@ protected Table createTable(String name, Schema schema,
PartitionSpec spec) {
TableOperations ops = ((BaseTable) table).operations();
TableMetadata meta = ops.current();
ops.commit(meta, meta.upgradeToFormatVersion(2));
- if (vectorized) {
+ table.updateProperties().set(TableProperties.DEFAULT_FILE_FORMAT,
format).commit();
+ if (format.equals("parquet") && vectorized) {
Review Comment:
I could have been mistaken, but when I started working on this, vectorized
read was only supported for parquet. For this reason, the parameters for the
testsuite only has vectorized=true for format=parquet. In any case, the
parameters give a fair coverage of both file formats and
vectorized/non-vectorized.
I think I understand your concern. If I understand it correctly, your
concern is with `TableProperties.ORC_VECTORIZATION_ENABLED` which currently
defaults to false. If format=orc, we want to set
`TableProperties.ORC_VECTORIZATION_ENABLED` explicitly in case the default
changes in the future.
I'll fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
