szehon-ho commented on code in PR #5510:
URL: https://github.com/apache/iceberg/pull/5510#discussion_r950661835
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -169,9 +170,14 @@ public boolean dropTable(TableIdentifier identifier,
boolean purge) {
TableOperations ops = newTableOps(identifier);
TableMetadata lastMetadata;
- if (purge && ops.current() != null) {
- lastMetadata = ops.current();
- } else {
+ try {
+ if (purge && ops.current() != null) {
+ lastMetadata = ops.current();
+ } else {
+ lastMetadata = null;
Review Comment:
Style nit: Wondering, while we are in this code, it may be a bit more
concise to initialize lastMetadata = null, then we can remove two null
assignments in the else/catch blocks? Not sure what people think, though its
not a big in any case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
