amogh-jahagirdar commented on code in PR #5595: URL: https://github.com/apache/iceberg/pull/5595#discussion_r952222322
########## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ########## @@ -451,8 +537,10 @@ private void validateNoNewDeletesForDataFiles( } /** - * Validates that no delete files matching a filter have been added to the table since a starting - * snapshot. + * ToDo: Remove after branch writing implementation complete Review Comment: We can remove the existing validate after we implement the different write operations because we will always have an ending snapshot. This is fine because these are all protected/private. ########## core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java: ########## @@ -451,8 +537,10 @@ private void validateNoNewDeletesForDataFiles( } /** - * Validates that no delete files matching a filter have been added to the table since a starting - * snapshot. + * ToDo: Remove after branch writing implementation complete Review Comment: We can remove the existing validate after we implement the different write operations because we will always have an ending snapshot. This is fine because validations are all protected/private. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
