amogh-jahagirdar commented on PR #5595: URL: https://github.com/apache/iceberg/pull/5595#issuecomment-1223652247
Looks like @namrathamyske also has a PR for this https://github.com/apache/iceberg/pull/5234/files/ , the approach is fundamentally the same but I was thinking it makes more sense to iterate on one operation at a time rather than doing all the merging snapshot producers at once. We can have copies of the validate methods which accept an ending snapshot. That way we can validate the code and tests for a single operation at a time which seems easier for review IMO, but open to discussion @namrathamyske @rdblue @jackye1995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
