ericlgoodman commented on code in PR #5331:
URL: https://github.com/apache/iceberg/pull/5331#discussion_r952995031


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/MigrateTableSparkAction.java:
##########
@@ -121,7 +121,7 @@ private MigrateTable.Result doExecute() {
 
       Some<String> backupNamespace = Some.apply(backupIdent.namespace()[0]);
       TableIdentifier v1BackupIdent = new TableIdentifier(backupIdent.name(), 
backupNamespace);
-      String stagingLocation = getMetadataLocation(icebergTable);
+      String stagingLocation = 
SparkTableUtil.getIcebergMetadataLocation(icebergTable);

Review Comment:
   Need to remove this change



##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/SnapshotTableSparkAction.java:
##########
@@ -124,7 +124,7 @@ private SnapshotTable.Result doExecute() {
       ensureNameMappingPresent(icebergTable);
 
       TableIdentifier v1TableIdent = v1SourceTable().identifier();
-      String stagingLocation = getMetadataLocation(icebergTable);
+      String stagingLocation = 
SparkTableUtil.getIcebergMetadataLocation(icebergTable);

Review Comment:
   Same here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to