aokolnychyi commented on code in PR #5601:
URL: https://github.com/apache/iceberg/pull/5601#discussion_r953063451
##########
api/src/main/java/org/apache/iceberg/transforms/Bucket.java:
##########
@@ -90,6 +96,11 @@ public Integer apply(T value) {
return (hash(value) & Integer.MAX_VALUE) % numBuckets;
}
+ @Override
+ public boolean canTransform(Type type) {
+ return type.isPrimitiveType();
Review Comment:
It seems like a valid point cause we still allow to construct `Bucket` for a
particular type. Should we deprecate or prohibit that? Or still override in
children?
```
static <T> Bucket<T> get(Type type, int numBuckets) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
