rdblue commented on code in PR #5364:
URL: https://github.com/apache/iceberg/pull/5364#discussion_r954255047
##########
core/src/main/java/org/apache/iceberg/BaseTableScan.java:
##########
@@ -86,20 +90,56 @@ public TableScan appendsAfter(long fromSnapshotId) {
public TableScan useSnapshot(long scanSnapshotId) {
Preconditions.checkArgument(
snapshotId() == null, "Cannot override snapshot, already set to
id=%s", snapshotId());
+ Preconditions.checkArgument(
+ ref() == null, "Cannot override snapshot, already set to id=%s",
ref());
Preconditions.checkArgument(
tableOps().current().snapshot(scanSnapshotId) != null,
"Cannot find snapshot with ID %s",
scanSnapshotId);
return newRefinedScan(
- tableOps(), table(), tableSchema(),
context().useSnapshotId(scanSnapshotId));
+ tableOps(),
+ table(),
+ tableSchema(),
+
context().useRef(SnapshotRef.MAIN_BRANCH).useSnapshotId(scanSnapshotId));
+ }
+
+ @Override
+ public TableScan useRef(String name) {
+ Preconditions.checkArgument(
+ snapshotId() == null, "Cannot override ref, already set to id=%s",
snapshotId());
+ Preconditions.checkArgument(ref() == null, "Cannot override ref, already
set to id=%s", ref());
+ SnapshotRef ref = tableOps().current().ref(name);
+ Preconditions.checkArgument(ref != null, "Cannot find ref %s", name);
+ long scanSnapshotId = ref.snapshotId();
+ return newRefinedScan(
+ tableOps(), table(), tableSchema(),
context().useRef(name).useSnapshotId(scanSnapshotId));
Review Comment:
Why set `ref` and the snapshot ID? It seems like this is going to cause
conflicts with `asOfTime`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
