findepi commented on code in PR #5450:
URL: https://github.com/apache/iceberg/pull/5450#discussion_r954271628


##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -817,6 +824,7 @@ public static class Builder {
     private long currentSnapshotId;
     private List<Snapshot> snapshots;
     private final Map<String, SnapshotRef> refs;
+    private final Map<Long, List<StatisticsFile>> statisticsFiles;

Review Comment:
   > Why use a multimap? 
   
   This is so per 
https://github.com/apache/iceberg/pull/5021#discussion_r936919462
   
   Please clarify where I can use a Map and where I should not, the lifecycle 
of these metadata objects is still not crystal clear to me
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to