amogh-jahagirdar commented on code in PR #5364:
URL: https://github.com/apache/iceberg/pull/5364#discussion_r954321236
##########
core/src/main/java/org/apache/iceberg/TableScanContext.java:
##########
@@ -75,7 +77,8 @@ private TableScanContext(
Long toSnapshotId,
ExecutorService planExecutor,
boolean fromSnapshotInclusive,
- ScanReporter scanReporter) {
+ ScanReporter scanReporter,
+ String ref) {
Review Comment:
It was required before because if we do useRef("branch").asOfTime(someTime)
the context acts as a placeholder to store the information for branches, so
that in the asOfTime we can choose the right ref. If we don't do time travel
with branches then yes we just need to set a snapshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
