jackye1995 commented on code in PR #5592:
URL: https://github.com/apache/iceberg/pull/5592#discussion_r954324718
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -193,6 +193,14 @@ public static <T extends SdkClientBuilder> void
configureEndpoint(T builder, Str
}
}
+ /**
+ * Build an S3Configuration object from two boolean flags, pathStyleAccess
and
Review Comment:
> Build an S3Configuration object from two boolean flags, pathStyleAccess
and s3UseArnRegionEnabled
This part is a bit too specific, since we are just deprecating it, we can
just have a simple message like "Build an S3 configuration object". The
parameters should be put in the `@param` lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
