kbendick commented on code in PR #5313: URL: https://github.com/apache/iceberg/pull/5313#discussion_r955658232
########## docs/configuration.md: ########## @@ -64,6 +64,8 @@ Iceberg tables support table properties to configure table behavior, like the de | write.orc.block-size-bytes | 268435456 (256 MB) | Define the default file system block size for ORC files | | write.orc.compression-codec | zlib | ORC compression codec: zstd, lz4, lzo, zlib, snappy, none | | write.orc.compression-strategy | speed | ORC compression strategy: speed, compression | +| write.orc.bloom.filter.columns | (not set) | Comma separated list of column names for which a Bloom filter must be created | +| write.orc.bloom.filter.fpp | 0.05 | False positive probability for Bloom filter (must > 0.0 and < 1.0) | Review Comment: I’m good with following up on anything in a new issue. This is almost there and we should leave it as is (minus any nits). Using configs similar to those offered by native file formats is a good call imo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
