amogh-jahagirdar commented on code in PR #5618:
URL: https://github.com/apache/iceberg/pull/5618#discussion_r956781597
##########
core/src/test/java/org/apache/iceberg/TestDeleteFiles.java:
##########
@@ -68,38 +68,46 @@ public class TestDeleteFiles extends TableTestBase {
))
.build();
+ private final String branch;
+
@Parameterized.Parameters(name = "formatVersion = {0}")
public static Object[] parameters() {
- return new Object[] {1, 2};
+ return new Object[][] {
+ new Object[] {1, "main"},
Review Comment:
That's correct, we test for every combination of format version + branch.
I'll need update the @Parameters so that we can get nicer test names. The
second parameter gets injected as an argument in the test file constructor.
##########
core/src/test/java/org/apache/iceberg/TestDeleteFiles.java:
##########
@@ -68,38 +68,46 @@ public class TestDeleteFiles extends TableTestBase {
))
.build();
+ private final String branch;
+
@Parameterized.Parameters(name = "formatVersion = {0}")
public static Object[] parameters() {
- return new Object[] {1, 2};
+ return new Object[][] {
+ new Object[] {1, "main"},
Review Comment:
That's correct, we test for every combination of format version + branch.
I'll need update the @Parameters so that we can get nicer test names. The
second parameter gets injected as an argument in the test class constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
