jun-he commented on code in PR #5462:
URL: https://github.com/apache/iceberg/pull/5462#discussion_r956889012
##########
python/pyiceberg/transforms.py:
##########
@@ -215,6 +228,221 @@ def __repr__(self) -> str:
return f"BucketTransform(num_buckets={self._num_buckets})"
+class TimeResolution(IntEnum):
+ YEAR = 6
+ MONTH = 5
+ WEEK = 4
+ DAY = 3
+ HOUR = 2
+ MINUTE = 1
+ SECOND = 0
+
+
+class TimeTransform(Transform[S, int]):
+ @property
+ @abstractmethod
+ def granularity(self) -> TimeResolution:
+ ...
+
+ def satisfies_order_of(self, other: Transform) -> bool:
+ return self.granularity <= other.granularity if hasattr(other,
"granularity") else False
+
+ def result_type(self, source: IcebergType) -> IcebergType:
+ return IntegerType()
+
+ @property
+ def dedup_name(self) -> str:
+ return "time"
+
+ @property
+ def preserves_order(self) -> bool:
+ return True
+
+
+class YearTransform(TimeTransform):
+ """Transforms a datetime value into a year value.
+
+ Example:
+ >>> transform = YearTransform()
+ >>> transform.transform(TimestampType())(1512151975038194)
+ 47
+ """
+
+ __root__: Literal["year"] = Field(default="year")
+ _source_type: IcebergType = PrivateAttr()
Review Comment:
Yep, removed `_source_type` from most of the transforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
