amogh-jahagirdar commented on code in PR #5669:
URL: https://github.com/apache/iceberg/pull/5669#discussion_r957971209
##########
core/src/main/java/org/apache/iceberg/RemoveSnapshots.java:
##########
@@ -357,180 +360,45 @@ private void cleanExpiredSnapshots() {
LOG.info("Committed snapshot changes; cleaning up expired manifests and
data files.");
- removeExpiredFiles(current.snapshots(), validIds, expiredIds);
+ removeExpiredFiles(base, current);
Review Comment:
What we may want to do is have 2 "strategies":
1.) If there is only a single branch, apply incremental expiration.
2.) If there are multiple branches, apply the reachability analysis.
That way we get the benefits of incremental expiration when it's applicable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
