Fokko commented on code in PR #5665:
URL: https://github.com/apache/iceberg/pull/5665#discussion_r958677816
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -212,7 +211,7 @@ public Set<TableCapability> capabilities() {
@Override
public MetadataColumn[] metadataColumns() {
- DataType sparkPartitionType =
SparkSchemaUtil.convert(Partitioning.partitionType(table()));
+ DataType sparkPartitionType =
SparkSchemaUtil.convert(table().spec().partitionType());
Review Comment:
Reading it a second time, and looking at the failing test, it makes sense to
me:
https://github.com/apache/iceberg/blob/dbb8a404f6632a55acb36e949f0e7b84b643cede/spark/v3.3/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java#L135-L166
We want to be able to jump back to earlier specs, and therefore we include
them in the struct of the metadata column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
