rdblue commented on code in PR #5437:
URL: https://github.com/apache/iceberg/pull/5437#discussion_r960104492


##########
build.gradle:
##########
@@ -379,6 +379,7 @@ project(':iceberg-aws') {
 
     testImplementation 'software.amazon.awssdk:iam'
     testImplementation 'software.amazon.awssdk:s3control'
+    testImplementation 'com.twitter:chill-java'

Review Comment:
   That means that this is not actually serializable with Kryo, then.
   
   Looks like the problem is that you're using 
`SerializableMap.copyOf(properties).immutableMap()`. Instead, you should store 
the copy and call `immutableMap()` in the `properties()` method to return the 
map to the caller.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to