gaborkaszab commented on code in PR #150:
URL: https://github.com/apache/iceberg-docs/pull/150#discussion_r960449967


##########
landing-page/content/common/catalog.md:
##########
@@ -0,0 +1,43 @@
+---
+title: "Iceberg Catalogs"
+url: concepts/catalog
+disableSidebar: true
+---
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements.  See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License.  You may obtain a copy of the License at
+ -
+ -   http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Iceberg Catalogs
+
+## Overview
+
+You may  think of Iceberg as a format for managing data in a single table, but 
the Iceberg library needs a way to keep track of those tables by name. Tasks 
like creating, dropping, and renaming tables are the responsibility of a 
catalog. Catalogs manage a collection of tables that are usually grouped into 
namespaces. The most important responsibility of a catalog is tracking a 
table's current metadata, which is provided by the catalog when you load a 
table.
+
+The first step when using an Iceberg client is almost always initializing and 
configuring a catalog. The configured catalog is then used by compute engines 
to execute catalog operations. Multiple types of compute engines using a shared 
Iceberg catalog allows them to share a common data layer. 
+
+A catalog is almost always configured through the processing engine which 
passes along a set of properties during initialization. Different processing 
engines have different ways to configure a catalog. When configuring a catalog, 
it’s always best to refer to the Iceberg documentation for the specific 
processing engine being used. Ultimately, these configurations boil down to a 
common set of catalog properties that will be passed to configure the Iceberg 
catalog.
+
+## Catalog Implementations

Review Comment:
   Is it intentional not to have full coverage on all the catalog 
implementations? e.g. GlueCatalog, HadoopCatalog



##########
landing-page/content/common/catalog.md:
##########
@@ -0,0 +1,43 @@
+---
+title: "Iceberg Catalogs"
+url: concepts/catalog
+disableSidebar: true
+---
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements.  See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License.  You may obtain a copy of the License at
+ -
+ -   http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Iceberg Catalogs
+
+## Overview
+
+You may  think of Iceberg as a format for managing data in a single table, but 
the Iceberg library needs a way to keep track of those tables by name. Tasks 
like creating, dropping, and renaming tables are the responsibility of a 
catalog. Catalogs manage a collection of tables that are usually grouped into 
namespaces. The most important responsibility of a catalog is tracking a 
table's current metadata, which is provided by the catalog when you load a 
table.

Review Comment:
   nit: Double space here: "You may  think"



##########
landing-page/content/common/catalog.md:
##########
@@ -0,0 +1,43 @@
+---
+title: "Iceberg Catalogs"
+url: concepts/catalog
+disableSidebar: true
+---
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements.  See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License.  You may obtain a copy of the License at
+ -
+ -   http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Iceberg Catalogs
+
+## Overview
+
+You may  think of Iceberg as a format for managing data in a single table, but 
the Iceberg library needs a way to keep track of those tables by name. Tasks 
like creating, dropping, and renaming tables are the responsibility of a 
catalog. Catalogs manage a collection of tables that are usually grouped into 
namespaces. The most important responsibility of a catalog is tracking a 
table's current metadata, which is provided by the catalog when you load a 
table.
+
+The first step when using an Iceberg client is almost always initializing and 
configuring a catalog. The configured catalog is then used by compute engines 
to execute catalog operations. Multiple types of compute engines using a shared 
Iceberg catalog allows them to share a common data layer. 
+
+A catalog is almost always configured through the processing engine which 
passes along a set of properties during initialization. Different processing 
engines have different ways to configure a catalog. When configuring a catalog, 
it’s always best to refer to the Iceberg documentation for the specific 
processing engine being used. Ultimately, these configurations boil down to a 
common set of catalog properties that will be passed to configure the Iceberg 
catalog.
+
+## Catalog Implementations

Review Comment:
   It's great to have a high-level description of these catalog 
implementations, but in the long run some more detailed description with some 
usage examples would be very useful.



##########
landing-page/content/common/catalog.md:
##########
@@ -0,0 +1,43 @@
+---
+title: "Iceberg Catalogs"
+url: concepts/catalog
+disableSidebar: true
+---
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements.  See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License"); you may not use this file except in compliance with
+ - the License.  You may obtain a copy of the License at
+ -
+ -   http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+# Iceberg Catalogs
+
+## Overview
+
+You may  think of Iceberg as a format for managing data in a single table, but 
the Iceberg library needs a way to keep track of those tables by name. Tasks 
like creating, dropping, and renaming tables are the responsibility of a 
catalog. Catalogs manage a collection of tables that are usually grouped into 
namespaces. The most important responsibility of a catalog is tracking a 
table's current metadata, which is provided by the catalog when you load a 
table.
+
+The first step when using an Iceberg client is almost always initializing and 
configuring a catalog. The configured catalog is then used by compute engines 
to execute catalog operations. Multiple types of compute engines using a shared 
Iceberg catalog allows them to share a common data layer. 
+
+A catalog is almost always configured through the processing engine which 
passes along a set of properties during initialization. Different processing 
engines have different ways to configure a catalog. When configuring a catalog, 
it’s always best to refer to the Iceberg documentation for the specific 
processing engine being used. Ultimately, these configurations boil down to a 
common set of catalog properties that will be passed to configure the Iceberg 
catalog.

Review Comment:
   "Iceberg documentation for the specific processing engine being used" Maybe 
a link here would be useful.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to