rdblue commented on code in PR #5601:
URL: https://github.com/apache/iceberg/pull/5601#discussion_r961856108
##########
api/src/main/java/org/apache/iceberg/transforms/Timestamps.java:
##########
@@ -27,48 +27,72 @@
import org.apache.iceberg.expressions.Expression;
import org.apache.iceberg.expressions.Expressions;
import org.apache.iceberg.expressions.UnboundPredicate;
+import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.types.Type;
import org.apache.iceberg.types.Types;
+import org.apache.iceberg.util.SerializableFunction;
enum Timestamps implements Transform<Long, Integer> {
YEAR(ChronoUnit.YEARS, "year"),
MONTH(ChronoUnit.MONTHS, "month"),
DAY(ChronoUnit.DAYS, "day"),
HOUR(ChronoUnit.HOURS, "hour");
+ static class Apply implements SerializableFunction<Long, Integer> {
+ private final ChronoUnit granularity;
+
+ Apply(ChronoUnit granularity) {
+ this.granularity = granularity;
+ }
+
+ @Override
+ public Integer apply(Long timestampMicros) {
+ if (timestampMicros == null) {
+ return null;
+ }
+
+ if (timestampMicros >= 0) {
+ OffsetDateTime timestamp =
+ Instant.ofEpochSecond(
Review Comment:
I decided not to modify this. I think it's a good suggestion, but messing
this up with a cut & paste error just would not be worth it :sweat_smile:.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
