stevenzwu commented on code in PR #5642:
URL: https://github.com/apache/iceberg/pull/5642#discussion_r962089556
##########
flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/sink/TestIcebergStreamWriter.java:
##########
@@ -233,7 +233,31 @@ public void testBoundedStreamCloseWithEmittingDataFiles()
throws Exception {
Assert.assertEquals(expectedDataFiles * 2, result.dataFiles().length);
}
}
+ @Test
+ public void testBoundedStreamTriggeredEndInputBeforeTriggeringCheckpoint()
throws Exception {
Review Comment:
@xuzhiwen1255 I also think it is a little weird that calling endInput twice
would send data files again. It is there since the very beginning of this test
class.
https://github.com/apache/iceberg/commit/7101c25b91287578e387f8c8cdc7f5547310171e#diff-7f9a59307eed16d49e8590463e52c94e2a2e5c46dd132b635991ffa7571ee164
cc @openinx in case there is some context that we missed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
