gaborkaszab commented on code in PR #5729:
URL: https://github.com/apache/iceberg/pull/5729#discussion_r965839064
##########
core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java:
##########
@@ -110,7 +110,7 @@ public static class TableMetadataSerializer extends
JsonSerializer<TableMetadata
@Override
public void serialize(TableMetadata metadata, JsonGenerator gen,
SerializerProvider serializers)
throws IOException {
- TableMetadataParser.toJson(metadata, gen);
+ TableMetadataParser.toJson(metadata, null, gen);
Review Comment:
Wouldn't providing null here for FileIO cause IllegalArgumentException in
BaseSnapshot.cacheManifests(FileIO)?
https://github.com/apache/iceberg/blob/c0f175b517edef5dd1b06a5ac7890fb35224bc25/core/src/main/java/org/apache/iceberg/BaseSnapshot.java#L178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
