rdblue commented on code in PR #4741:
URL: https://github.com/apache/iceberg/pull/4741#discussion_r966204993


##########
core/src/main/java/org/apache/iceberg/GenericStatisticsFile.java:
##########
@@ -18,13 +18,14 @@
  */
 package org.apache.iceberg;
 
+import java.io.Serializable;
 import java.util.List;
 import java.util.Objects;
 import java.util.StringJoiner;
 import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
 import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
 
-public class GenericStatisticsFile implements StatisticsFile {
+public class GenericStatisticsFile implements StatisticsFile, Serializable {

Review Comment:
   Oh, I see. For `SerializableTable`. I don't think that we need to actually 
serialize these. Instead, you can delegate to `lazyTable()` like some of the 
other methods. We don't expect serialized versions to use this since it is for 
planning on the coordinator or driver.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to