nastra commented on code in PR #5729:
URL: https://github.com/apache/iceberg/pull/5729#discussion_r967225100


##########
core/src/main/java/org/apache/iceberg/rest/RESTSerializers.java:
##########
@@ -110,7 +110,7 @@ public static class TableMetadataSerializer extends 
JsonSerializer<TableMetadata
     @Override
     public void serialize(TableMetadata metadata, JsonGenerator gen, 
SerializerProvider serializers)
         throws IOException {
-      TableMetadataParser.toJson(metadata, gen);
+      TableMetadataParser.toJson(metadata, null, gen);

Review Comment:
   I have revisited the code around this area and having a dependency on 
`FileIO` in Snapshot for the single purpose of reading/writing `manifests` 
turned out to be quite tricky. However, I think I found an acceptable approach 
to deal with this in https://github.com/apache/iceberg/pull/5734.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to