dhruv-pratap opened a new pull request, #5736: URL: https://github.com/apache/iceberg/pull/5736
The three sub-level options within properties are a bit inconsistent with one-another. <img width="951" alt="image" src="https://user-images.githubusercontent.com/11399509/189404842-64c50ff4-0a4b-4db0-a8cb-c1f6179c1536.png"> The Get Properties CLI at present expects a choice option `entity`. <img width="954" alt="image" src="https://user-images.githubusercontent.com/11399509/189406369-f1b3a19b-d096-48dc-b880-8c99180ddce6.png"> This is inconsistent with the way we have defined set and remove CLI option, where-in they have two sub-level commands for table and namespace which is much more cleaner IMO. <img width="947" alt="image" src="https://user-images.githubusercontent.com/11399509/189405688-c8981530-3a42-4215-afeb-e9d9f499e134.png"> This PR makes the Get Properties CLI options consistent with Set and Remove CLI options and look like below. <img width="951" alt="image" src="https://user-images.githubusercontent.com/11399509/189406114-87ba1e56-5944-4aa6-b383-517eadc3f338.png"> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
