aokolnychyi commented on code in PR #5740:
URL: https://github.com/apache/iceberg/pull/5740#discussion_r967524811
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -579,23 +565,68 @@ private static void checkNotPathIdentifier(Identifier
identifier, String method)
}
}
- private Pair<Table, Long> load(Identifier ident) {
+ private Table load(Identifier ident, String version) {
Review Comment:
I am using existing options for configuring boundaries. This means we cannot
use SQL right now. Only the DF API. Hopefully, we will have support for options
in Spark 3.4.
An alternative option is to add a stored procedure to generate a changelog
and register it as a view. We will need the procedure in any case to generate
pre and pos images. I am reluctant to use table identifiers as it makes the
logic tricky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
