Fokko commented on code in PR #5707:
URL: https://github.com/apache/iceberg/pull/5707#discussion_r967862277
##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -380,7 +380,12 @@ static TableMetadata fromJson(FileIO io, String
metadataLocation, JsonNode node)
// parse the spec array
ImmutableList.Builder<PartitionSpec> builder = ImmutableList.builder();
for (JsonNode spec : specArray) {
- builder.add(PartitionSpecParser.fromJson(schema, spec));
+ UnboundPartitionSpec unboundSpec = PartitionSpecParser.fromJson(spec);
+ if (unboundSpec.specId() == defaultSpecId) {
+ builder.add(unboundSpec.bind(schema));
Review Comment:
Thanks for linking @singhpk234, and that is indeed a very clear explanation
and it makes a lot of sense.
I've added a condition to skip the validation when we encounter a
`VoidTransform`. Since it is almost always compatible, I think we should be
okay with that, but curious to hear what others think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
