joshuarobinson commented on code in PR #5747:
URL: https://github.com/apache/iceberg/pull/5747#discussion_r969304903
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -35,13 +36,14 @@
OutputFile,
OutputStream,
)
+from pyiceberg.typedef import Properties
class PyArrowFile(InputFile, OutputFile):
"""A combined InputFile and OutputFile implementation that uses a pyarrow
filesystem to generate pyarrow.lib.NativeFile instances
Args:
- location(str): A URI or a path to a local file
Review Comment:
I now agree with you on this point and will change back to "location"
originally I changed the name because the value being passed here is
explicitly *not* a URI anymore (per the from_uri() call in pyarrow) so I
thought a different name would be better. But 'location' already means uri OR
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
