JonasJ-ap commented on code in PR #5684:
URL: https://github.com/apache/iceberg/pull/5684#discussion_r972459064
##########
aws/src/test/java/org/apache/iceberg/aws/TestAwsClientFactories.java:
##########
@@ -56,24 +52,6 @@ public void testLoadCustom() {
"should load custom class", AwsClientFactories.from(properties)
instanceof CustomFactory);
}
- @Test
Review Comment:
Thank you for pointing this out. I forgot to add the test after deleting the
original one. Since now the `applyS3CredentialConfigurations` locate in
`AwsProperties.java`, I added a new test called
`testS3FileIoCredentialsConfiguration()` in `TestAwsProperties.java` with
similar testing logic like the deleted one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
