pvary commented on code in PR #5775:
URL: https://github.com/apache/iceberg/pull/5775#discussion_r973547766
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java:
##########
@@ -164,6 +167,18 @@ private static Configuration mergeHiveConf(Configuration
hadoopConf, String hive
newConf.addResource(configFile);
}
}
+ if (!Strings.isNullOrEmpty(hadoopConfDir)) {
Review Comment:
Nit: we keep adding an extra line after a block. This is also done in the PR
we are merging here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
