findepi commented on code in PR #5776: URL: https://github.com/apache/iceberg/pull/5776#discussion_r973600221
########## docs/configuration.md: ########## @@ -39,7 +39,7 @@ Iceberg tables support table properties to configure table behavior, like the de | read.split.metadata-target-size | 33554432 (32 MB) | Target size when combining metadata input splits | | read.split.planning-lookback | 10 | Number of bins to consider when combining input splits | | read.split.open-file-cost | 4194304 (4 MB) | The estimated cost to open a file, used as a minimum weight when combining splits. | -| read.parquet.vectorization.enabled| false | Enables parquet vectorized reads | +| read.parquet.vectorization.enabled| true | Enables parquet vectorized reads | Review Comment: > two flavors of descriptions for configuration options suffixed by `.enabled`, I think the difference may come from the distinction whether the option is on or off by default. For something that's off by default, the wording "Enables ..." is appropriate. For something that's on by default, it's no longer as nice IMO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
