findepi commented on code in PR #5799:
URL: https://github.com/apache/iceberg/pull/5799#discussion_r974970624


##########
core/src/main/java/org/apache/iceberg/TableMetadataParser.java:
##########
@@ -225,6 +226,12 @@ public static void toJson(TableMetadata metadata, 
JsonGenerator generator) throw
     }
     generator.writeEndArray();
 
+    generator.writeArrayFieldStart(STATISTICS);

Review Comment:
   Deserialization already exists.
   
https://github.com/apache/iceberg/blob/fca6101f5847ee27feaa5aeb78fe25110e1af6a9/core/src/main/java/org/apache/iceberg/TableMetadataParser.java#L466
   Was added in https://github.com/apache/iceberg/pull/5450
   
   The fact serialization was not covered was an omission.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to