JonasJ-ap commented on code in PR #5784:
URL: https://github.com/apache/iceberg/pull/5784#discussion_r973655330
##########
aws/src/integration/java/org/apache/iceberg/aws/TestAssumeRoleAwsClientFactory.java:
##########
@@ -75,7 +75,7 @@ public void before() {
assumeRoleProperties = Maps.newHashMap();
assumeRoleProperties.put(AwsProperties.CLIENT_FACTORY,
AssumeRoleAwsClientFactory.class.getName());
assumeRoleProperties.put(AwsProperties.HTTP_CLIENT_TYPE,
AwsProperties.HTTP_CLIENT_TYPE_APACHE);
- assumeRoleProperties.put(AwsProperties.CLIENT_ASSUME_ROLE_REGION,
"us-east-1");
+ assumeRoleProperties.put(AwsProperties.CLIENT_ASSUME_ROLE_REGION,
AwsIntegTestUtil.testRegion());
Review Comment:
If the bucket is created in a different region, I think we should use the
region specified by the user to perform integration tests. Otherwise, we may
get a 400 bad request error when sending a request from `us-east-1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
