rdblue commented on code in PR #5303:
URL: https://github.com/apache/iceberg/pull/5303#discussion_r975777214
##########
python/tests/expressions/test_expressions_base.py:
##########
@@ -841,3 +924,290 @@ def test_not_expression_binding(unbound_not_expression,
expected_bound_expressio
"""Test that visiting an unbound NOT expression with a bind-visitor
returns the expected bound expression"""
bound_expression = base.visit(unbound_not_expression,
visitor=base.BindVisitor(schema=table_schema_simple))
assert bound_expression == expected_bound_expression
+
+
+def test_bound_boolean_expression_visitor_ignore_is_nan_for_string_type():
+ """Test ignoring IsNan expressions when the field type is a String"""
Review Comment:
We don't need validation in the visitor. We should assume that the bound
expression has been created correctly by the binding process and not by people
instantiating the expressions directly. Maybe we should also move these into
`bound.py` to avoid exposing them?
We also need to understand why the expression was skipped. That sounds like
a bug to me. I don't think there's anything that checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
