flyrain commented on code in PR #5793:
URL: https://github.com/apache/iceberg/pull/5793#discussion_r975888307
##########
core/src/main/java/org/apache/iceberg/LocationProviders.java:
##########
@@ -125,13 +122,7 @@ static class ObjectStoreLocationProvider implements
LocationProvider {
private static String dataLocation(Map<String, String> properties, String
tableLocation) {
String dataLocation =
properties.get(TableProperties.WRITE_DATA_LOCATION);
if (dataLocation == null) {
- dataLocation = properties.get(TableProperties.OBJECT_STORE_PATH);
- if (dataLocation == null) {
- dataLocation =
properties.get(TableProperties.WRITE_FOLDER_STORAGE_LOCATION);
- if (dataLocation == null) {
- dataLocation = String.format("%s/data", tableLocation);
- }
- }
Review Comment:
I don't want to make it more complex, but does it make sense to have a tool
to migrate tables from old versions to 1.0? We can replace the deprecated
properties with the tool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
