nastra commented on code in PR #5407: URL: https://github.com/apache/iceberg/pull/5407#discussion_r972083963
########## core/src/main/java/org/apache/iceberg/rest/requests/ScanReportRequest.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest.requests; + +import org.apache.iceberg.metrics.ScanReport; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.rest.RESTRequest; + +public class ScanReportRequest implements RESTRequest { Review Comment: I took a quite similar approach to what you suggested with some minor differences by introducing a `SendMetricsRequestParser` and renaming this class to `SendMetricsRequest`. The `SendMetricsRequestParser` is currently missing some unit tests but it should be good enough to outline the approach taken. The idea there is that we built a `SendMetricsRequest` based on a scan report/commit report/x (currently there's only `ScanReport`). This class then also determines the metric type from that. The `SendMetricsRequestParser` sends a `metrics-type` and a `metrics-value`. On the receiving side we'd have to check the `metrics-type` and use the appropriate method to retrieve the right report (`SendMetricsRequest.scanReport()` / `SendMetricsRequest.commitReport()` / ...). This approach allows to encapsulate everything related to sending metrics and determining metric types within a single place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
