samredai commented on code in PR #5303:
URL: https://github.com/apache/iceberg/pull/5303#discussion_r976808752
##########
python/tests/expressions/test_expressions_base.py:
##########
@@ -104,17 +109,95 @@ def visit_test_expression_b(self) -> List:
@base.visit.register(ExpressionA)
-def _(obj: ExpressionA, visitor: BooleanExpressionVisitor) -> List:
+def _(obj: ExpressionA, visitor: FooBooleanExpressionVisitor) -> List:
"""Visit a ExpressionA with a BooleanExpressionVisitor"""
return visitor.visit_test_expression_a()
@base.visit.register(ExpressionB)
-def _(obj: ExpressionB, visitor: BooleanExpressionVisitor) -> List:
+def _(obj: ExpressionB, visitor: FooBooleanExpressionVisitor) -> List:
"""Visit a ExpressionB with a BooleanExpressionVisitor"""
return visitor.visit_test_expression_b()
+class
FooBoundBooleanExpressionVisitor(base.BoundBooleanExpressionVisitor[List]):
Review Comment:
I originally had it as `TestBoundBooleanExpressionVisitor` but since classes
that start with `Test` is a pytest convention, the test suite was getting
confused. How about `ExampleVisitor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
