rdblue commented on code in PR #5773:
URL: https://github.com/apache/iceberg/pull/5773#discussion_r978091844
##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -153,35 +139,22 @@ static Snapshot fromJson(FileIO io, JsonNode node) {
Integer schemaId = JsonUtil.getIntOrNull(SCHEMA_ID, node);
- if (node.has(MANIFEST_LIST)) {
Review Comment:
This is still needed. If Iceberg is reading an old table that embeds the
manifest list locations, then there's no reason why it should fail. That would
be a backward-incompatible change. As long as we don't write out a form with
the manifests, we should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
