rdblue commented on code in PR #5815:
URL: https://github.com/apache/iceberg/pull/5815#discussion_r978094424
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -268,8 +268,7 @@ CloseableIterable<ManifestEntry<F>> liveEntries() {
/** @return an Iterator of DataFile. Makes defensive copies of files before
returning */
@Override
public CloseableIterator<F> iterator() {
- return CloseableIterable.transform(
- liveEntries(), e -> e.file().copy(!dropStats(rowFilter, columns)))
+ return CloseableIterable.transform(liveEntries(), e ->
e.file().copy(!dropStats(columns)))
Review Comment:
I realize that this isn't changing what's already done, but I think it would
be better to have a variable for the result of `dropStats`. That's not going to
change and we don't need to evaluate whether to drop stats for the columns
every time this runs!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
