danielcweeks commented on PR #4518: URL: https://github.com/apache/iceberg/pull/4518#issuecomment-1256505449
> > Hi @danielcweeks that looks like a nice cleanup. But I have 2 concerns: > > 1. By pushing the config verification down to `ContentCache` constructor, that will make `ContentCache` less generic and more specific towards manifest caching use. Is that OK? > 2. If we keep `fileio` as a class member of `ContentCache`, that becomes a strong reference to `fileio`. Thus, the `weakKeys()` in `CONTENT_CACHES` is not useful anymore because there is always a strong reference to that `FileIO` key living in `ContentCache` object (the value)? Good points. Let me take one more pass (I was just hoping to consolidate more of the logic in ContentCache, but you're probably right that it makes more sense to keep the manifest settings with ManifestFiles). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
