flyrain commented on PR #5844:
URL: https://github.com/apache/iceberg/pull/5844#issuecomment-1256790055
The test jar doesn't include any third party class, it should just use the
`libthrift` in the test runtime classpath. Not sure why there is a mistmach.
```
| => jar -tf
./hive-metastore/.out/libs/iceberg-hive-metastore-0.13.0-apple-preview-5-SNAPSHOT-tests.jar
META-INF/
META-INF/MANIFEST.MF
org/
org/apache/
org/apache/iceberg/
org/apache/iceberg/hive/
org/apache/iceberg/hive/HiveCreateReplaceTableTest.class
org/apache/iceberg/hive/HiveMetastoreTest.class
org/apache/iceberg/hive/HiveTableBaseTest.class
org/apache/iceberg/hive/HiveTableTest.class
org/apache/iceberg/hive/ScriptRunner.class
org/apache/iceberg/hive/TestCachedClientPool.class
org/apache/iceberg/hive/TestHiveCatalog.class
org/apache/iceberg/hive/TestHiveClientPool.class
org/apache/iceberg/hive/TestHiveCommitLocks.class
org/apache/iceberg/hive/TestHiveCommits.class
org/apache/iceberg/hive/TestHiveMetastore.class
org/apache/iceberg/hive/TestHiveSchemaUtil.class
org/apache/iceberg/hive/TestHiveTableConcurrency.class
hive-schema-3.1.0.derby.sql
```
It may be due to different libthrift versions in your test runtime. Can you
try to exclude the thrift lib when you add iceberg-hive-metastore as a
dependency?
```
| => ./gradlew clean :iceberg-hive-metastore:dependencyInsight
--configuration testcompileClasspath --dependency libthrift
> Task :iceberg-hive-metastore:dependencyInsight
org.apache.thrift:libthrift:0.9.3
variant "compile" [
org.gradle.status = release (not requested)
org.gradle.usage = java-api
org.gradle.libraryelements = jar (compatible with: classes)
org.gradle.category = library
Requested attributes not found in the selected variant:
org.gradle.dependency.bundling = external
org.gradle.jvm.environment = standard-jvm
org.gradle.jvm.version = 8
]
org.apache.thrift:libthrift:0.9.3
+--- org.apache.hive:hive-metastore:2.3.8
| \--- testCompileClasspath (requested org.apache.hive:hive-metastore)
+--- org.apache.hive:hive-serde:2.3.8
| \--- org.apache.hive:hive-metastore:2.3.8 (*)
+--- org.apache.hive:hive-service-rpc:2.3.8
| \--- org.apache.hive:hive-serde:2.3.8 (*)
+--- org.apache.hive.shims:hive-shims-common:2.3.8
| \--- org.apache.hive:hive-shims:2.3.8
| +--- org.apache.hive:hive-metastore:2.3.8 (*)
| +--- org.apache.hive:hive-serde:2.3.8 (*)
| +--- org.apache.hive:hive-common:2.3.8
| | \--- org.apache.hive:hive-serde:2.3.8 (*)
| \--- org.apache.hive:hive-exec:2.3.8
| \--- testCompileClasspath (requested
org.apache.hive:hive-exec)
\--- org.apache.thrift:libfb303:0.9.3
+--- org.apache.hive:hive-metastore:2.3.8 (*)
\--- org.apache.hive:hive-service-rpc:2.3.8 (*)
(*) - dependencies omitted (listed previously)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
