marton-bod commented on code in PR #4602:
URL: https://github.com/apache/iceberg/pull/4602#discussion_r980124236
##########
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAlterTablePartitionFields.java:
##########
@@ -421,6 +421,78 @@ public void testSparkTableAddDropPartitions() throws
Exception {
"spark table partition should be empty", 0,
sparkTable().partitioning().length);
}
+ @Test
+ public void testUnboundPartitionSpecFormatVersion1() throws Exception {
+ sql(
Review Comment:
Just an idea: since both tests are identical except for the `format-version`
property in the create statement, maybe we could combine them and supply the
format-version as a parameter in a loop?
```
IntStream.rangeClosed(1, 2).forEach(version -> {
... // sql statements
});
```
This way it could be easily extended for future versions as well. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
