aokolnychyi commented on code in PR #5740:
URL: https://github.com/apache/iceberg/pull/5740#discussion_r980538571
##########
core/src/main/java/org/apache/iceberg/MetadataColumns.java:
##########
@@ -75,6 +75,21 @@ private MetadataColumns() {}
public static final String DELETE_FILE_ROW_FIELD_NAME = "row";
public static final int DELETE_FILE_ROW_FIELD_ID = Integer.MAX_VALUE - 103;
public static final String DELETE_FILE_ROW_DOC = "Deleted row values";
+ public static final NestedField CHANGELOG_OPERATION =
+ NestedField.required(
+ Integer.MAX_VALUE - 104,
+ "changelog_operation",
+ Types.StringType.get(),
+ "Record type in changelog");
+ public static final NestedField CHANGE_ORDINAL =
+ NestedField.optional(
+ Integer.MAX_VALUE - 105, "change_ordinal", Types.IntegerType.get(),
"Change ordinal");
Review Comment:
I am following the name in `ChangelogScanTask`.
Let's discuss whether these columns are metadata columns or reserved columns
to see if we need to start with an underscore.
##########
core/src/main/java/org/apache/iceberg/MetadataColumns.java:
##########
@@ -75,6 +75,21 @@ private MetadataColumns() {}
public static final String DELETE_FILE_ROW_FIELD_NAME = "row";
public static final int DELETE_FILE_ROW_FIELD_ID = Integer.MAX_VALUE - 103;
public static final String DELETE_FILE_ROW_DOC = "Deleted row values";
+ public static final NestedField CHANGELOG_OPERATION =
+ NestedField.required(
+ Integer.MAX_VALUE - 104,
+ "changelog_operation",
+ Types.StringType.get(),
+ "Record type in changelog");
+ public static final NestedField CHANGE_ORDINAL =
+ NestedField.optional(
+ Integer.MAX_VALUE - 105, "change_ordinal", Types.IntegerType.get(),
"Change ordinal");
Review Comment:
I am following the name in `ChangelogScanTask`. Let's discuss whether these
columns are metadata columns or reserved columns to see if we need to start
with an underscore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
