aokolnychyi commented on PR #5789: URL: https://github.com/apache/iceberg/pull/5789#issuecomment-1259713575
Okay, I merged #5679 as it fixes the nullability propagation. I am still debating what should be a correct fix for MoR, though. The problem is that `MergeRows` can indeed produce nullable values for what's considered non-nullable columns if we have a delete action in MoR. For deleted rows in MoR, we will nullify all attributes except row ID and metadata columns. Yes, those delete rows will not be passed to the data source but the node can produce nulls. The current solution works because there is no code after `MergeRows` but if there was, we can be in trouble. Let me think a bit more. Maybe, we can adapt the validation in `WriteDelta` a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
