Fokko commented on code in PR #5869: URL: https://github.com/apache/iceberg/pull/5869#discussion_r981490800
########## python/README.md: ########## @@ -35,7 +35,7 @@ Development is made easy using [Poetry](https://python-poetry.org/docs/#installa ```bash poetry shell -poetry install -E pyarrow +poetry install -E pyarrow -E hive -E s3fs Review Comment: Thanks @nastra, great catch! It seems that this is outdated. What do you think of: ```sh make install make test ``` This way we just have to maintain the `Makefile`, that is also being used in the CI. Makefile: https://github.com/apache/iceberg/blob/master/python/Makefile#L18-L20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
