flyrain commented on PR #5742: URL: https://github.com/apache/iceberg/pull/5742#issuecomment-1259916069
Hi @wypoon, sorry I may not be clear in my last comment. Let me explain a bit more. 1. No matter whether the pos deletes are streamed or not. Most logic has already been tested by the cases in `TestSparkReaderDeletes`, which including the logic of mix of pos deletes and eq deletes. 2. The only thing we forget to test is that, in case of streaming pos deletes, whether the count logic is correct, mainly what happens in the class `PositionStreamDeleteFilter`. `TestPositionFilter` will the right place for a unit test. 3. BTW, I’m OK with the system property approach if there is no other way to approach it. It’s a bit hacky. In this case, I'd think it is not necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
