singhpk234 commented on code in PR #4402:
URL: https://github.com/apache/iceberg/pull/4402#discussion_r981999890
##########
aws/src/main/java/org/apache/iceberg/aws/glue/GlueCatalog.java:
##########
@@ -199,20 +199,33 @@ void initialize(
protected TableOperations newTableOps(TableIdentifier tableIdentifier) {
if (catalogProperties != null) {
ImmutableMap.Builder<String, String>
tableSpecificCatalogPropertiesBuilder =
- ImmutableMap.<String, String>builder()
- .putAll(catalogProperties)
- .put(
- AwsProperties.LAKE_FORMATION_DB_NAME,
- IcebergToGlueConverter.getDatabaseName(
- tableIdentifier,
awsProperties.glueCatalogSkipNameValidation()))
- .put(
- AwsProperties.LAKE_FORMATION_TABLE_NAME,
- IcebergToGlueConverter.getTableName(
- tableIdentifier,
awsProperties.glueCatalogSkipNameValidation()));
+ ImmutableMap.<String, String>builder().putAll(catalogProperties);
- if (awsProperties.glueLakeFormationEnabled()) {
+ if (awsProperties.s3WriteTableTagEnabled()) {
+ tableSpecificCatalogPropertiesBuilder.put(
+
AwsProperties.S3_WRITE_TAGS_PREFIX.concat(AwsProperties.S3_TAG_ICEBERG_TABLE),
+ IcebergToGlueConverter.getTableName(
+ tableIdentifier,
awsProperties.glueCatalogSkipNameValidation()));
Review Comment:
[minor] can extract this into local vars to be reused in both places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
